Functions: fixing S4 ORM #10596
Functions: fixing S4 ORM #10596
Conversation
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6155009757 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6155023612 |
| @@ -0,0 +1,7 @@ | |||
| -- +goose Up | |||
There was a problem hiding this comment.
Use "s4" in the file name instead of "functions".
| @@ -71,7 +71,7 @@ RETURNING id;`, o.tableName) | |||
| if errors.Is(err, sql.ErrNoRows) { | |||
| return ErrVersionTooLow | |||
| } | |||
| return nil | |||
| return err | |||
There was a problem hiding this comment.
Is it possible to trigger as error here in a test? It looks like it should never happen now...
There was a problem hiding this comment.
It will be hard to trigger, e.g. close DB connection..
| @@ -0,0 +1,7 @@ | |||
| -- +goose Up | |||
|
|
|||
| ALTER TABLE "s4".shared ALTER COLUMN version TYPE BIGINT; | |||
There was a problem hiding this comment.
Can you add (or modify) a test to actually save a version larger than INT?
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6157416552 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6157425045 |
|
SonarQube Quality Gate
|
No description provided.