update streams lookup contracts #10607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
shileiwill
reviewed
Sep 12, 2023
| @@ -93,7 +93,7 @@ contract StreamsLookupUpkeep is AutomationCompatibleInterface, StreamsLookupComp | |||
| return (false, data); | |||
| } | |||
| uint256 timeParam; | |||
| if (keccak256(abi.encodePacked(timeParamKey)) == keccak256(abi.encodePacked("feedIdHex"))) { | |||
| if (keccak256(abi.encodePacked(feedParamKey)) == keccak256(abi.encodePacked("feedIdHex"))) { | |||
There was a problem hiding this comment.
Hey @FelixFan1992 , i know this is a simple change, and this is all about this PR, I wish I could just approve. Can you help me understand what are timeParamKey and feedParamKey, why this change? Thanks~
There was a problem hiding this comment.
sure. timeParamKey is either blockNumber or timestamp
feedParamKey is either feedIdHex or feedIDs. these are used to differentiate v2 and v3
|
SonarQube Quality Gate
|
shileiwill
approved these changes
Sep 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.