Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci-lint gha for chaincli #10732

Merged
merged 36 commits into from
Oct 10, 2023
Merged

Conversation

momentmaker
Copy link
Collaborator

@momentmaker momentmaker commented Sep 20, 2023

This creates a separate GHA workflow to lint the chaincli code.

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

core/web/middleware.go Outdated Show resolved Hide resolved
@momentmaker momentmaker marked this pull request as draft September 20, 2023 21:09
@momentmaker momentmaker marked this pull request as ready for review September 22, 2023 09:19
.github/workflows/ci-chaincli.yml Outdated Show resolved Hide resolved
.github/workflows/ci-chaincli.yml Outdated Show resolved Hide resolved
chainchad
chainchad previously approved these changes Sep 22, 2023
@momentmaker momentmaker marked this pull request as ready for review September 22, 2023 22:12
@momentmaker
Copy link
Collaborator Author

@chainchad @HenryNguyen5 could you please review this again? I added a composite action ci-golang-lint and using it in ci-chaincli and ci-core :)

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chainchad chainchad added this pull request to the merge queue Oct 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2023
@chainchad chainchad added this pull request to the merge queue Oct 10, 2023
Merged via the queue into develop with commit 37673f4 Oct 10, 2023
84 checks passed
@chainchad chainchad deleted the feature/re-1696-add-ci-lint-chaincli branch October 10, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants