Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging for cache #11453

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Improve logging for cache #11453

merged 5 commits into from
Dec 6, 2023

Conversation

samsondav
Copy link
Collaborator

@samsondav samsondav commented Dec 1, 2023 •
edited
Loading

  • Include ServerURL in cache logging
  • Add additional cache tracing
  • Silence overly verbose Debug logging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@samsondav samsondav changed the title cache debugging Improve logging for cache Dec 4, 2023
@samsondav samsondav marked this pull request as ready for review December 4, 2023 15:35
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.9% 76.9% Coverage
0.0% 0.0% Duplication

@samsondav samsondav added this pull request to the merge queue Dec 6, 2023
Merged via the queue into develop with commit 47d0690 Dec 6, 2023
88 checks passed
@samsondav samsondav deleted the cache_debugging branch December 6, 2023 18:28
fbac pushed a commit that referenced this pull request Dec 14, 2023
@samsondav
Improve logging for cache (#11453)
c121be1 
* Include ServerURL in cache logging

* Add additional cache tracing

* TEMP - DO NOT MERGE THIS - promote Trace=>Debug cache logging

* Log if call was cached or not

* Revert "TEMP - DO NOT MERGE THIS - promote Trace=>Debug cache logging"

This reverts commit f0f3f07a59c8d310ac74849519d46ea9b53495c1.
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-cll martin-cll martin-cll approved these changes

@sdrug sdrug Awaiting requested review from sdrug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsondav @martin-cll