Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-590] Logstream with buffered streaming to Loki #11477

Merged
merged 45 commits into from
Dec 7, 2023

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Dec 4, 2023

This PR updates code and integration tests pipelines to send Chainlink nodes logs to Loki, when test fails. It also prints links for all failed tests to Grafana Dashboard that allows to easily check logs.

As a backup we also save logs to files so that they can be downloaded as artefacts (just as before).

Copy link
Contributor

github-actions bot commented Dec 4, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@Tofel Tofel marked this pull request as ready for review December 6, 2023 20:16
@Tofel Tofel requested review from a team as code owners December 6, 2023 20:16
@Tofel Tofel changed the title [TT-590] Logwatch with buffered streaming [TT-590] Logstream with buffered streaming to Loki Dec 6, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@skudasov skudasov self-requested a review December 7, 2023 22:02
@skudasov skudasov added this pull request to the merge queue Dec 7, 2023
Merged via the queue into develop with commit 711987f Dec 7, 2023
74 checks passed
@skudasov skudasov deleted the tt_590_log_watch_second_approach branch December 7, 2023 22:24
fbac pushed a commit that referenced this pull request Dec 14, 2023
* testing out with local CTF

* print location for failed tests

* use logwatch with buffer

* try logwatch with loki and test targets in CI

* fix merge conflict

* fix lint issue

* adjust env vars in workflow

* add logwatch env vars as env and not with

* fix env var name

* fix go.mod

* use newer ctf

* fix go.sum

* use correct ctf version

* fix go.sum

* trigger tests

* small debug

* make the Gh summary print a bit nicer

* latest ctf, use var not secret for grafana url

* update ctf, change how we print test summary

* shutdown logwatch after flushing logs

* trigger tests

* use latest ctf where logwatch -> logstream

* update var name in GH workflow

* enable log stream for all smoke tests

* use better method for logstream shutdown and log flushing

* fix compile error

* latest ctf, remove comment

* remove replace from go.mod

* collect all logs to see what happens

* update ctf, better scoped dashboard link

* do not save logs if test doesn't fail

* print absolute log folder path

* cause test failure to make sure file logs are where they should be

* fix typo in var declaration in gh workflow

* run go mod tidy for integeration tests

* always execute test summary step

* remove failing vrfv2 test on purpose

* use taggeg CTF version

* connect mock adapter to logstream

* initialise killgrave only when necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants