go.mods: rm libp2p; rm btcd replace #11502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
force-pushed
the
btcd
branch
8 times, most recently
from
a1046e1
to
ab12fad
Compare
jmank88
force-pushed
the
btcd
branch
4 times, most recently
from
5fa5e21
to
dd6f541
Compare
jmank88
changed the title
samsondav
previously approved these changes
Dec 11, 2023
|
SonarQube Quality Gate
|
jmank88
requested review from
coventry,
gtklocker,
kaleofduty and
secure-lorenz
jmank88
commented
Dec 11, 2023
| if err != nil { | ||
| return EncryptedP2PKeyExport{}, errors.Wrapf(err, "could not get raw public key") | ||
| } | ||
| func(id string, key KeyV2, cryptoJSON keystore.CryptoJSON) EncryptedP2PKeyExport { |
There was a problem hiding this comment.
This was the only instance actually returning an error, so we can simplify the signature now.
coventry
reviewed
Dec 11, 2023
jmank88
commented
Dec 11, 2023
There was a problem hiding this comment.
Just filled these out to match the slightly stricter length validation.
samsondav
approved these changes
Dec 11, 2023
momentmaker
added a commit
that referenced
this pull request
Dec 13, 2023
* develop: (56 commits) [TT-367] [TT-745] Quick and Dirty OCRv2 Soak Test (#11487) [FUN-990] s4 observability improvements (#11512) fix health monitoring (#11558) Removes Optimism Goerli from Scheduled Tests (#11559) bump Foundry to the December release (#11540) Standardize LP filter logging (#11515) Change keepers to use the default contract transmitter (#11308) bump toml/v2 and prometheus to latest patch (#11541) Remove big from core utils (#11511) Handle edge case involving blocks not being found in the db (#11298) [DEPLOY-178]: Adds Scroll L2EP Contracts (#11405) disable kaniko fallback, increase deploy wait timeout (#11548) Use multiple EL clients with ocrv2 median smoke test (#11399) Remove core utils dependencies from common (#11425) [BCF-2760] Flakey test detection improvements (#11470) go.mods: rm libp2p; rm btcd replace (#11502) wrap devspace commands (#11530) small improvements based on comments (#11491) (test): Remove unnecessary fuzzing from Functions OnTokenTransfer tests (#11517) core/scripts/common: rm ava-labs/coreth; lint (#11451) ...
fbac
pushed a commit
that referenced
this pull request
Dec 14, 2023
* go.mods: drop btcd replace; upgrade libp2p * Replace deprecated call to btcd API for secp256k1 constant * Fix comment describing sqrtPower calculation * Change calculation of sqrtPower to standard order of operations * rm libp2p peer & crypto uses --------- Co-authored-by: Alex Coventry <coventry@smartcontract.com>
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #10872, we can remove the remaining libp2p deps and drop the
github.com/btcsuite/btcdreplaces.