Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct references to TXM DB from external component tests #11538

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

amit-momin
Copy link
Contributor

  • Expanded TxStore test functions to cover needed use cases for external components' tests
  • Replaced direct references to the TXM DB in external tests with new methods added to the TxStore

Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@amit-momin amit-momin force-pushed the remove-txm-db-refs-in-tests branch 3 times, most recently from 0d14ce4 to 6af6e48 Compare December 11, 2023 23:12
@amit-momin amit-momin marked this pull request as ready for review December 11, 2023 23:49
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

jmank88
jmank88 previously approved these changes Dec 12, 2023
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Dec 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 14, 2023
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Dec 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 14, 2023
@cl-sonarqube-production
Copy link

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Dec 14, 2023
Merged via the queue into develop with commit 7773d03 Dec 14, 2023
83 of 84 checks passed
@prashantkumar1982 prashantkumar1982 deleted the remove-txm-db-refs-in-tests branch December 14, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants