-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove direct references to TXM DB from external component tests #11538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amit-momin
commented
Dec 11, 2023
- Expanded TxStore test functions to cover needed use cases for external components' tests
- Replaced direct references to the TXM DB in external tests with new methods added to the TxStore
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
amit-momin
force-pushed
the
remove-txm-db-refs-in-tests
branch
3 times, most recently
from
December 11, 2023 23:12
0d14ce4
to
6af6e48
Compare
amit-momin
force-pushed
the
remove-txm-db-refs-in-tests
branch
from
December 11, 2023 23:39
6af6e48
to
afa6f6d
Compare
amit-momin
requested review from
jkongie,
jmank88,
samsondav,
a team and
prashantkumar1982
as code owners
December 11, 2023 23:49
prashantkumar1982
previously approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
jmank88
previously approved these changes
Dec 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 14, 2023
amit-momin
dismissed stale reviews from prashantkumar1982 and jmank88
via
December 14, 2023 21:11
aa7e7a7
SonarQube Quality Gate |
prashantkumar1982
approved these changes
Dec 14, 2023
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.