BCI-2508: TXM duplicate nonces caused by trasmitchecker #11546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/chains/evm/txmgr/evm_tx_store.go
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
dhaidashenko
requested review from
samsondav,
prashantkumar1982 and
a team
as code owners
poopoothegorilla
approved these changes
Dec 13, 2023
|
SonarQube Quality Gate
|
amit-momin
approved these changes
Dec 15, 2023
prashantkumar1982
approved these changes
Dec 19, 2023
|
Looks really solid! |
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run checker only for unstarted transactions to prevent marking broadcasted and included transactions as fatally errored
This ticket describes it in more details.