Adds MAKE Command for Building Plugin Image #11567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
SonarQube Quality Gate
|
ilija42
approved these changes
Dec 13, 2023
nolag
reviewed
Dec 13, 2023
| # tag: the tag for the chainlink image being built, example: tag=latest | ||
| # example usage: make build_docker_image image=chainlink tag=latest | ||
| .PHONY: build_plugin_docker_image | ||
| build_docker_image: |
There was a problem hiding this comment.
This is the same target as the one above, I think it's supposed to be build_plugin_docker_image
There was a problem hiding this comment.
Yep, TY for pointing out
fbac
pushed a commit
that referenced
this pull request
Dec 14, 2023
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.