Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added smoke test for canceling subscription on VRFv2 #11587

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

ibrajer
Copy link
Contributor

@ibrajer ibrajer commented Dec 15, 2023

  • Added smoke tests for owner and subscriber canceling subscription on VRFv2

  • Extended v2 coordinator contract model with WaitForSubscriptionCanceledEvent and OwnerCancelSubscription

@ibrajer ibrajer requested a review from a team December 15, 2023 17:56
@ibrajer ibrajer self-assigned this Dec 15, 2023
@ibrajer ibrajer requested a review from a team as a code owner December 15, 2023 17:56
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@dkneisly dkneisly force-pushed the chore/VRF-806-v2-cancel-sub-test branch 2 times, most recently from c5a609f to 25564bb Compare December 18, 2023 17:16
ibrajer and others added 2 commits December 18, 2023 09:20
* Added smoke test for canceling subscription on VRFv2

* Extended v2 coordinator contract model with WaitForSubscriptionCanceledEvent
@dkneisly dkneisly force-pushed the chore/VRF-806-v2-cancel-sub-test branch from 25564bb to daf6453 Compare December 18, 2023 17:20
@iljapavlovs
Copy link
Collaborator

lgtm

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ibrajer ibrajer added this pull request to the merge queue Dec 19, 2023
Merged via the queue into develop with commit d4ab877 Dec 19, 2023
84 checks passed
@ibrajer ibrajer deleted the chore/VRF-806-v2-cancel-sub-test branch December 19, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants