Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Test_Client_LatestReport to parameterized test #11670

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Refactoring Test_Client_LatestReport to parameterized test #11670

merged 1 commit into from
Jan 3, 2024

Conversation

patrickhuie19
Copy link
Contributor

Test_Client_LatestReport now:

  • is parameterized
  • removes a nil cacheset test that was not adding to coverage

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

I see that you haven't updated any README files. Would it make sense to do so?

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patrickhuie19 patrickhuie19 marked this pull request as ready for review January 2, 2024 18:33
@patrickhuie19 patrickhuie19 added this pull request to the merge queue Jan 3, 2024
Merged via the queue into develop with commit adfa4bd Jan 3, 2024
79 checks passed
@patrickhuie19 patrickhuie19 deleted the chore/wsrpc_cache_param_test branch January 3, 2024 20:47
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@samsondav samsondav Awaiting requested review from samsondav

@sdrug sdrug Awaiting requested review from sdrug

@martin-cll martin-cll Awaiting requested review from martin-cll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickhuie19 @jmank88