Chore/rm eventbroadcaster entirely #11727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
krehermann
force-pushed
the
chore/rm-eventbroadcaster-entirely
branch
from
f8c0861
to
5f38ffb
Compare
krehermann
requested review from
jkongie,
jmank88 and
samsondav
as code owners
samsondav
reviewed
Jan 10, 2024
There was a problem hiding this comment.
Nice work Keith. Surprised that the TXM doesn't still use it...
It should be possible to remove our dependency on pq now also, I don't see that removed in this PR.
You may also wish to check the DB for any TRIGGER code, and remove it if there is still something there.
jmank88
approved these changes
Jan 10, 2024
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mercury was the last real use case of event broadcaster. that use case was removed in (80bc9f2) with subsequent cleanup of the evm code in ( b0da965) and ( 768edec)
this change removes all remaining vestiges of the event broadcaster