feature/gin-tracing: adding gin tracing to core #11796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
patrickhuie19
force-pushed
the
feature/gin-tracing
branch
from
0fb7906
to
0f9eb7e
Compare
patrickhuie19
force-pushed
the
feature/gin-tracing
branch
from
0f9eb7e
to
f9140fb
Compare
krehermann
previously approved these changes
Jan 17, 2024
patrickhuie19
force-pushed
the
feature/gin-tracing
branch
from
f9140fb
to
d065e7a
Compare
|
SonarQube Quality Gate
|
jmank88
approved these changes
Jan 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds traces to core web routes (tracks execution once the request hits the remote node). They are not all that interesting, and right now only report latency.
I considered wiring through individually configured Enabled and SamplingRate for this component, but decided against the additional complexity. We can add it later if requested/needed.