Wiring context for EVM Keys API #11800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
patrickhuie19
force-pushed
the
feature/sql-tracing
branch
from
1d8e874
to
9eeb413
Compare
krehermann
reviewed
Jan 18, 2024
patrickhuie19
force-pushed
the
feature/sql-tracing
branch
from
125f45c
to
4cd18c3
Compare
patrickhuie19
force-pushed
the
feature/sql-tracing
branch
2 times, most recently
from
e6bbbe8
to
8448f0c
Compare
patrickhuie19
force-pushed
the
feature/sql-tracing
branch
from
bf5f3f5
to
b66cb73
Compare
patrickhuie19
force-pushed
the
feature/sql-tracing
branch
from
b66cb73
to
61f8f6c
Compare
patrickhuie19
force-pushed
the
feature/sql-tracing
branch
from
d61f6c1
to
8713b34
Compare
patrickhuie19
changed the title
patrickhuie19
force-pushed
the
feature/sql-tracing
branch
from
9acf905
to
b79255f
Compare
jmank88
reviewed
Feb 20, 2024
jmank88
reviewed
Feb 20, 2024
| @@ -177,7 +177,7 @@ func newFunctionsContractTransmitter(contractVersion uint32, rargs commontypes.R | |||
| if sendingKeysLength > 1 && s == effectiveTransmitterAddress.String() { | |||
| return nil, errors.New("the transmitter is a local sending key with transaction forwarding enabled") | |||
| } | |||
| if err := ethKeystore.CheckEnabled(common.HexToAddress(s), configWatcher.chain.Config().EVM().ChainID()); err != nil { | |||
| if err := ethKeystore.CheckEnabled(ctx, common.HexToAddress(s), configWatcher.chain.Config().EVM().ChainID()); err != nil { | |||
There was a problem hiding this comment.
I think we should create a ticket to follow up with investigating each constructor that now requires context. Hopefully they are all just database related, but even that can be a problem, since a temporary hiccup during start-up could short-circuit things arbitrarily.
…d parent context for tracker state
jmank88
reviewed
Feb 26, 2024
jmank88
reviewed
Feb 26, 2024
jmank88
reviewed
Feb 26, 2024
jmank88
reviewed
Feb 26, 2024
jmank88
reviewed
Feb 26, 2024
jmank88
reviewed
Feb 26, 2024
jmank88
reviewed
Feb 26, 2024
jmank88
reviewed
Feb 26, 2024
jmank88
reviewed
Feb 26, 2024
jmank88
reviewed
Feb 26, 2024
…ontext() in web routes, and marks TODOs where needed
jmank88
reviewed
Feb 26, 2024
jmank88
reviewed
Feb 26, 2024
|
jmank88
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiring context through the EVM Keys API. Makes the db sql middleware added in #12097 more useful.