Fix dependencies for chainlink, chainlink-dev, and chainlink-test #11886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
reductionista
requested review from
jmank88,
krehermann,
a team,
chainchad,
javuto,
jkongie and
samsondav
as code owners
Previously, running "make chainlink" and similar commands used to be able to rebuild the chainlink executable. That stopped working recently, after some dependency changes. This will allow it to rebuild without needing to explicitly run "rm chainlink" each time you modify the source code or change branches.
reductionista
force-pushed
the
fix_makefile_dependencies
branch
from
a2c5142
to
3f470bf
Compare
jmank88
approved these changes
Jan 24, 2024
|
SonarQube Quality Gate
|
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running "make chainlink" and similar commands used to be able to rebuild the chainlink executable after you've modified source code or changed branches
That stopped working recently, after some dependency changes: it will always refuse to rebuild no matter what branch you switch to, unless you explicitly remove the previous executable.
This should restore the previous behavior, allowing us to rebuild chainlink without explicitly running "rm chainlink" each time.