Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for custom config poller onchain codec (LLO support) #11957

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Allow for custom config poller onchain codec (LLO support) #11957

merged 7 commits into from
Feb 13, 2024

Conversation

samsondav
Copy link
Collaborator

@samsondav samsondav commented Feb 7, 2024 •
edited
Loading

This PR doesn't make much sense unless you view in the context of enabling this: #10810

@samsondav samsondav requested a review from a team as a code owner February 7, 2024 17:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

I see that you haven't updated any README files. Would it make sense to do so?

@samsondav samsondav force-pushed the MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec branch from a7977e8 to 1c73a2d Compare February 8, 2024 00:13
@samsondav samsondav force-pushed the MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec branch from 90edd93 to 5f737d5 Compare February 9, 2024 14:51
@samsondav samsondav force-pushed the MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec branch from 5f737d5 to 3e0b260 Compare February 9, 2024 14:52
@samsondav samsondav force-pushed the MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec branch from 3e0b260 to 43ce912 Compare February 9, 2024 17:59
@samsondav samsondav force-pushed the MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec branch from b316932 to ffe9bf3 Compare February 13, 2024 14:46
krehermann
krehermann reviewed Feb 13, 2024
View reviewed changes
core/services/relay/evm/config_poller.go
}

func configPollerFilterName(addr common.Address) string {
return logpoller.FilterName("OCR2ConfigPoller", addr.String())
}

func NewConfigPoller(lggr logger.Logger, client client.Client, destChainPoller logpoller.LogPoller, aggregatorContractAddr common.Address, configStoreAddr *common.Address) (evmRelayTypes.ConfigPoller, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this signature is getting unwieldy. since you are making a break signature change anyway, i would make a config struct to house much of this stuff. maybe ~ NewConfigPoller(lggr, cfg)

@samsondav samsondav force-pushed the MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec branch from 9e81dd6 to b1e3364 Compare February 13, 2024 18:05
@samsondav samsondav force-pushed the MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec branch from b1e3364 to cc70a2f Compare February 13, 2024 18:10
jmank88
jmank88 previously approved these changes Feb 13, 2024
View reviewed changes
krehermann
krehermann previously approved these changes Feb 13, 2024
View reviewed changes
jmank88
jmank88 previously approved these changes Feb 13, 2024
View reviewed changes
@samsondav samsondav dismissed stale reviews from krehermann and jmank88 via de9f941 February 13, 2024 19:44
@samsondav samsondav force-pushed the MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec branch from 9875d44 to de9f941 Compare February 13, 2024 19:44
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
2 New issues
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
83.8% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube

@samsondav samsondav added this pull request to the merge queue Feb 13, 2024
Merged via the queue into develop with commit 2380220 Feb 13, 2024
93 checks passed
@samsondav samsondav deleted the MERC-3487-benchmark-test-mercury-parallel-compositions-custom-config-poller-codec branch February 13, 2024 21:34
momentmaker added a commit that referenced this pull request Feb 15, 2024
@momentmaker
Merge branch 'develop' into re-2202/update-goreleaser-workflow
03122b7 
* develop: (74 commits)
  VRF zero confirmation delay  (#11947)
  add toml configs to paths that can cause e2e tests to run in ci (#12001)
  bump golang.org/x/... (#12042)
  [chore] Replace clock with specialized lib (#12031)
  Update style guide (#12041)
  plugins/cmd/chainlink-mercury: (re)move to chainlink-data-streams repo (#11994)
  bump go-plugin (#12033)
  Adds timeout on fuzz script execution (#12024)
  Add bytes type to abi_type (#12029)
  AUTO-8804: create chain specific modules for l1 gas calculations (#11896)
  VRF-878 Gas Optimization V2 Plus (#11982)
  Improving deletes performance by limiting number of records to scan (#12007)
  core/web: improve health CLI readabilty (#12021)
  Handle a 0 exit code from the remote runner instead of always failing (#12015)
  Add a simple Codec test (#12006)
  Allow for custom config poller onchain codec (LLO support) (#11957)
  Update Sonar properties (#11986)
  golangci-lint: revive: add early-return; fix issues (#12017)
  Implement NewPluginProvider (EVM) (#11995)
  Fix lock file version and minor NPM bumps (#11980)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@krehermann krehermann Awaiting requested review from krehermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsondav @jmank88 @krehermann