Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pnpm i #11998

Merged
merged 1 commit into from
Feb 13, 2024
Merged

pnpm i #11998

merged 1 commit into from
Feb 13, 2024

Conversation

samsondav
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@RensR
Copy link
Contributor

RensR commented Feb 12, 2024

Covered by #11980

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@samsondav samsondav requested review from jmank88 and a team February 13, 2024 14:52
@jmank88
Copy link
Contributor

jmank88 commented Feb 13, 2024

How does this become out of sync? Should make pnpmdep be a pre-req of make operator-ui? Something like that would include this in the 'tidy/generate' CI check to prevent it from going out of sync.

@samsondav samsondav added this pull request to the merge queue Feb 13, 2024
Merged via the queue into develop with commit c89a15a Feb 13, 2024
105 checks passed
@samsondav samsondav deleted the lockfile_changed branch February 13, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@jmank88 jmank88 jmank88 approved these changes

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samsondav @RensR @jmank88 @vyzaldysanchez