Stream fallback: error handler #12061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* return timeout for retry interval * identify retryTimeout + placeholder for err handler * err codes * comments * added function and tests for handling err code
* err codes for conditionals * unit tests for conditional
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
infiloop2
reviewed
Feb 19, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/encoding/interface.go
Outdated
Show resolved
Hide resolved
…r, fix some minor comments (typo and test)
…handler Call check error handler within mercury
infiloop2
changed the base branch from
release/2.9.0
to
release-2.9.1-automation-20240220
infiloop2
reviewed
Feb 21, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/mercury/v03/request.go
Outdated
Show resolved
Hide resolved
infiloop2
approved these changes
Feb 23, 2024
- server timeout - unauthorized - bad req - internal server err - not found
shileiwill
approved these changes
Feb 23, 2024
…er-integration-test Error handler integration test
CRIB Environment Details ℹ️CRIB activated via the 'crib' label. To destroy the environment, remove the 'crib' PR label or close the PR. Please review the following details: SubdomainsUse these subdomains to access the CRIB environment. They are prefixes to the internal base domain.
|
|
|
Closing PR since github UI is not updating with latest commits. Will open up a new one and link here |
|
New PR #12173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-9004