Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancun Hardfork: support for new Transaction type #12063

Merged
merged 9 commits into from
Feb 26, 2024
Merged

Cancun Hardfork: support for new Transaction type #12063

merged 9 commits into from
Feb 26, 2024

Conversation

simsonraj
Copy link
Contributor

@simsonraj simsonraj commented Feb 16, 2024 •
edited
Loading

Ticket: https://smartcontract-it.atlassian.net/browse/SHIP-1032

Including the new transaction type(0x3) in Gas estimator

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@simsonraj simsonraj changed the title testing block unparsing Cancun Hardfork: support for new Transaction type Feb 19, 2024
@simsonraj simsonraj marked this pull request as ready for review February 20, 2024 15:04
@simsonraj simsonraj requested a review from a team as a code owner February 20, 2024 15:04
@friedemannf friedemannf added the build-test-image Will build the e2e test image in integration-tests workflow for PRs label Feb 20, 2024
dimriou
dimriou requested changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@dimriou dimriou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to figure out if max_priority_fee_per_gas is priced lower in blob transactions compared to 0x0 and 0x2 because there is an added cost from max_fee_per_blob_gas

friedemannf
friedemannf previously approved these changes Feb 23, 2024
View reviewed changes
@simsonraj simsonraj added this pull request to the merge queue Feb 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2024
@simsonraj simsonraj added this pull request to the merge queue Feb 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2024
@simsonraj simsonraj added this pull request to the merge queue Feb 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2024
@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@simsonraj simsonraj added this pull request to the merge queue Feb 26, 2024
Merged via the queue into develop with commit 7e41738 Feb 26, 2024
97 checks passed
@simsonraj simsonraj deleted the cancun-hardfork branch February 26, 2024 10:16
jinhoonbang pushed a commit that referenced this pull request Feb 29, 2024
@simsonraj @prashantkumar1982 @jinhoonbang
Cancun Hardfork: support for new Transaction type (#12063)
be0d241 
* testing block unparsing

* Pdded arsing tests for 0x3

* Adding type 0x3 to gas estimator

* Sonar cube code quality fix

---------

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
jinhoonbang added a commit that referenced this pull request Feb 29, 2024
@jinhoonbang @poopoothegorilla
@prashantkumar1982 @simsonraj
Release 2.9.1 vrf 20240229 dencun (#12239)
8054189 
* change error log to warn log (#12204)

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>

* Cancun Hardfork: support for new Transaction type (#12063)

* testing block unparsing

* Pdded arsing tests for 0x3

* Adding type 0x3 to gas estimator

* Sonar cube code quality fix

---------

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>

---------

Co-authored-by: Jim W <poopoothegorilla@users.noreply.github.com>
Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
Co-authored-by: Simson <simsonraj.easvarasakthi@smartcontract.com>
simsonraj added a commit that referenced this pull request Mar 1, 2024
@simsonraj @prashantkumar1982
Cancun Hardfork: support for new Transaction type (#12063)
4a2a73c 
* testing block unparsing

* Pdded arsing tests for 0x3

* Adding type 0x3 to gas estimator

* Sonar cube code quality fix

---------

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
simsonraj added a commit that referenced this pull request Mar 1, 2024
@simsonraj @prashantkumar1982
Cancun Hardfork: support for new Transaction type (#12063) (#12257)
af8dbd2 
* testing block unparsing

* Pdded arsing tests for 0x3

* Adding type 0x3 to gas estimator

* Sonar cube code quality fix

---------

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
anirudhwarrier pushed a commit that referenced this pull request Mar 1, 2024
@simsonraj @prashantkumar1982 @anirudhwarrier
Cancun Hardfork: support for new Transaction type (#12063)
96154fe 
* testing block unparsing

* Pdded arsing tests for 0x3

* Adding type 0x3 to gas estimator

* Sonar cube code quality fix

---------

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
anirudhwarrier added a commit that referenced this pull request Mar 1, 2024
@anirudhwarrier @simsonraj @prashantkumar1982
Cancun Hardfork: support for new Transaction type (#12063) (#12260)
2bba122 
* testing block unparsing

* Pdded arsing tests for 0x3

* Adding type 0x3 to gas estimator

* Sonar cube code quality fix

---------

Co-authored-by: Simson <simsonraj.easvarasakthi@smartcontract.com>
Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
simsonraj added a commit that referenced this pull request Mar 4, 2024
@simsonraj @prashantkumar1982
Cancun Hardfork: support for new Transaction type (#12063)
6ad69bb 
* testing block unparsing

* Pdded arsing tests for 0x3

* Adding type 0x3 to gas estimator

* Sonar cube code quality fix

---------

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
simsonraj added a commit that referenced this pull request Mar 5, 2024
@simsonraj @prashantkumar1982
Include 0x3 type transactions in gas estimatrion (#12286)
3dbca37 
* Cancun Hardfork: support for new Transaction type (#12063)

* testing block unparsing

* Pdded arsing tests for 0x3

* Adding type 0x3 to gas estimator

* Sonar cube code quality fix

---------

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>

* Updated changelog for Blob transaction type inclusion

---------

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
@dimriou dimriou mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HelloKashif HelloKashif HelloKashif left review comments

@friedemannf friedemannf friedemannf approved these changes

@dimriou dimriou dimriou left review comments

@jmank88 jmank88 Awaiting requested review from jmank88

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

Assignees
No one assigned
Labels
build-test-image Will build the e2e test image in integration-tests workflow for PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simsonraj @HelloKashif @dimriou @prashantkumar1982 @friedemannf