Rename xdai ChainType config to gnosis #12093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
davidcauchi
previously approved these changes
Feb 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…nd add warning if still used.
friedemannf
added
the
build-test-image
jmank88
reviewed
Feb 20, 2024
jmank88
reviewed
Feb 21, 2024
jmank88
reviewed
Feb 21, 2024
jmank88
reviewed
Feb 21, 2024
… into SHIP-1067/rename-xdai-chaintype
jmank88
previously approved these changes
Feb 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…dai-chaintype # Conflicts: # docs/CHANGELOG.md
friedemannf
removed
the
build-test-image
|
jmank88
approved these changes
Mar 9, 2024
ogtownsend
pushed a commit
that referenced
this pull request
Mar 14, 2024
* feat: rename xdai ChainType config to gnosis due to the chain rebranding (SHIP-1067) * chore: demote pyroscope-go * chore: rename more occurrences of xdai * refactor: retain old value for compatibility reasons, but deprecate and add warning if still used. * fix: golangci-lint * refactor: move deprecation warning to deprecationWarnings() * refactor: sort chainTypes alphabetically and add exhaustive switch stmts * bump deprecating version for xdai chaintype to v2.13.0 * remove changelog entry and add changeset * fix config test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect the current name of Gnosis chain by changing the
ChainTypeconfig value fromxdaitognosis.The old value of
xdaiis being deprecated but will continue to receive support for the next two upcoming releases (2.11 & 2.12). If it is being used, a value warning will be issued, reminding the user to switch to the new value. The bundled defaults for Gnosis mainnet & testnet already include the switch tognosis, requiring no action by the user if no custom config has been set.In v2.13.0, the old value of
xdaiwill be removed, requiring all users to be updated to the new value by then.