New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCF-2854 Jfpc pipeline cache #12094

Merged

ilija42 merged 29 commits into develop from jfpc-pipeline-cache

Feb 27, 2024

Contributor

ilija42 commented Feb 20, 2024 •

edited

Loading

Seems like the least invasive way of doing this. Putting this into libocr makes it hard to configure the cache

ilija42 added 5 commits

February 19, 2024 16:16


          Add rough implementation for data source caching

e4104c8


          Add JuelsPerFeeCoinCacheDuration validation

4253b9b


          Make sonar happy

c7cd2bb


          Set EATelemetry for dataSource in observe to reuse executeRun for cache

612a764


          Fix races in inMemoryDataSourceCache

a0898ee

ilija42 temporarily deployed to sdlc

February 20, 2024 12:54

— with

GitHub Actions Inactive

Contributor

github-actions bot commented Feb 20, 2024

I see that you haven't updated any README files. Would it make sense to do so?

ilija42 marked this pull request as ready for review

February 20, 2024 14:18

ilija42 requested a review from a team as a code owner

February 20, 2024 14:18

ilija42 marked this pull request as draft

February 20, 2024 14:18


          Fix JuelsPerFeeCoinCacheDuration validation

b4df428

ilija42 temporarily deployed to sdlc

February 20, 2024 14:21

— with

GitHub Actions Inactive

ilija42 marked this pull request as ready for review

February 20, 2024 14:51

ilija42 changed the title ~~Jfpc pipeline cache~~ Jfpc pipeline cache - BCF-2854

ilija42 changed the title ~~Jfpc pipeline cache - BCF-2854~~ BCF-2854 Jfpc pipeline cache

krehermann reviewed

View reviewed changes

core/services/ocr2/plugins/median/config/config.go Outdated Show resolved Hide resolved

krehermann reviewed

View reviewed changes

core/services/ocr2/plugins/median/config/config.go Outdated Show resolved Hide resolved

krehermann reviewed

View reviewed changes

core/services/ocr2/plugins/median/services.go Outdated Show resolved Hide resolved

krehermann reviewed

View reviewed changes

core/services/ocrcommon/data_source.go Outdated Show resolved Hide resolved

krehermann reviewed

View reviewed changes

core/services/ocrcommon/data_source.go Outdated Show resolved Hide resolved

krehermann reviewed

View reviewed changes

core/services/ocrcommon/data_source.go Show resolved Hide resolved

ilija42 added 2 commits

February 22, 2024 15:39


          Shorten NewInMemoryDataSourceCache signature

f4af456


          Infer juels fee per coin caching from non-zero duration instead of bool

7c46013

ilija42 temporarily deployed to sdlc

February 22, 2024 14:43

— with

GitHub Actions Inactive

ilija42 requested a review from krehermann

February 22, 2024 14:44

EasterTheBunny requested changes

View reviewed changes

core/services/ocrcommon/data_source.go Outdated Show resolved Hide resolved

ilija42 temporarily deployed to sdlc

February 22, 2024 21:27

— with

GitHub Actions Inactive

ilija42 force-pushed the jfpc-pipeline-cache branch from 3773583 to 7bbf1c8 Compare

February 22, 2024 21:42

ilija42 temporarily deployed to sdlc

February 22, 2024 21:42

— with

GitHub Actions Inactive

ilija42 force-pushed the jfpc-pipeline-cache branch from 7bbf1c8 to 2f580cf Compare

February 22, 2024 21:52

ilija42 requested a review from krehermann

February 27, 2024 13:25

ilija42 enabled auto-merge

February 27, 2024 15:07

krehermann previously approved these changes

View reviewed changes

ilija42 dismissed krehermann’s stale review via

c254871

February 27, 2024 15:22

ilija42 temporarily deployed to sdlc

February 27, 2024 15:22

— with

GitHub Actions Inactive

ilija42 force-pushed the jfpc-pipeline-cache branch from c254871 to a18a107 Compare

February 27, 2024 15:23

ilija42 temporarily deployed to sdlc

February 27, 2024 15:23

— with

GitHub Actions Inactive

ilija42 force-pushed the jfpc-pipeline-cache branch from a18a107 to 3d18d6c Compare

February 27, 2024 15:25

ilija42 temporarily deployed to sdlc

February 27, 2024 15:25

— with

GitHub Actions Inactive


          Fix log

5bf2e79

ilija42 force-pushed the jfpc-pipeline-cache branch from 3d18d6c to 5bf2e79 Compare

February 27, 2024 15:29

ilija42 temporarily deployed to sdlc

February 27, 2024 15:29

— with

GitHub Actions Inactive

ilija42 requested a review from krehermann

February 27, 2024 15:29

krehermann approved these changes

View reviewed changes

ilija42 requested a review from EasterTheBunny

February 27, 2024 16:01


          Merge branch 'develop' into jfpc-pipeline-cache

b7d1645

ilija42 temporarily deployed to sdlc

February 27, 2024 16:05

— with

GitHub Actions Inactive

ilija42 disabled auto-merge

February 27, 2024 16:07

ilija42 enabled auto-merge

February 27, 2024 16:07

EasterTheBunny approved these changes

View reviewed changes


          Merge branch 'develop' into jfpc-pipeline-cache

7c1f470

ilija42 temporarily deployed to sdlc

February 27, 2024 16:37

— with

GitHub Actions Inactive

ilija42 disabled auto-merge

February 27, 2024 17:11


          Merge branch 'develop' into jfpc-pipeline-cache

4db30d3

ilija42 temporarily deployed to sdlc

February 27, 2024 17:16

— with

GitHub Actions Inactive

cl-sonarqube-production bot commented Feb 27, 2024

Quality Gate passed

Issues
0 New issues
0 Fixed issues
1 Accepted issue

Measures
0 Security Hotspots
83.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

ilija42 added this pull request to the merge queue

Merged via the queue into develop with commit 23f767f

97 checks passed

ilija42 deleted the jfpc-pipeline-cache branch

February 27, 2024 18:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet