AUTO-9017: polish chain modules #12105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
FelixFan1992
requested review from
a team,
infiloop2 and
RyanRHall
and removed request for
a team
infiloop2
reviewed
Feb 22, 2024
infiloop2
reviewed
Feb 26, 2024
| /// @dev reference: https://docs.scroll.io/en/developers/transaction-fees-on-scroll/#estimating-the-l1-data-fee | ||
| address private constant SCROLL_ORACLE_ADDR = 0x5300000000000000000000000000000000000002; | ||
| IScrollL1GasPriceOracle private constant SCROLL_ORACLE = IScrollL1GasPriceOracle(SCROLL_ORACLE_ADDR); | ||
|
|
||
| uint256 private constant FIXED_GAS_OVERHEAD = 20000; | ||
| uint256 private constant PER_CALLDATA_BYTE_GAS_OVERHEAD = 20; | ||
| uint256 private constant FIXED_GAS_OVERHEAD = 15000; |
There was a problem hiding this comment.
Should this be 45000 based on sheet? (cost with 0x calldata)
There was a problem hiding this comment.
the gas cost calculated by g1 - g2 is about 45K
infiloop2
reviewed
Feb 26, 2024
| /// @dev OVM_GASPRICEORACLE_ADDR is the address of the OVM_GasPriceOracle precompile on Optimism. | ||
| /// @dev reference: https://community.optimism.io/docs/developers/build/transaction-fees/#estimating-the-l1-data-fee | ||
| address private constant OVM_GASPRICEORACLE_ADDR = 0x420000000000000000000000000000000000000F; | ||
| OVM_GasPriceOracle private constant OVM_GASPRICEORACLE = OVM_GasPriceOracle(OVM_GASPRICEORACLE_ADDR); | ||
|
|
||
| uint256 private constant FIXED_GAS_OVERHEAD = 20000; | ||
| uint256 private constant PER_CALLDATA_BYTE_GAS_OVERHEAD = 20; | ||
| uint256 private constant FIXED_GAS_OVERHEAD = 30000; |
There was a problem hiding this comment.
Should this be 60000 based on sheet?
There was a problem hiding this comment.
yes the gas cost calculated by g1 - g2 is about 60K
infiloop2
reviewed
Feb 26, 2024
infiloop2
reviewed
Feb 26, 2024
|
infiloop2
approved these changes
Feb 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.