change FindNextUnstartedTransactionFromAddress method signature #12124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replacing inplace
poopoothegorilla
temporarily deployed
to
sdlc
GitHub Actions
Inactive
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
poopoothegorilla
temporarily deployed
to
sdlc
GitHub Actions
Inactive
prashantkumar1982
approved these changes
Feb 22, 2024
poopoothegorilla
temporarily deployed
to
sdlc
GitHub Actions
Inactive
|
prashantkumar1982
deleted the
jtw/update-find-next-unstarted-transaction-from-address
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the
FindNextUnstartedTransactionFromAddressto return a transaction rather than replacing a passed in transaction. This was breaking linting rules and does not seem to have a benefit. It also does not seem to follow the patterns of other method signatures.