[VRF-892] Remove noisy log poller warning for VRFv2(+) jobs #12132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
vreff
requested review from
kidambisrinivas,
leeyikjiun,
jinhoonbang,
masha256 and
iljapavlovs
leeyikjiun
previously approved these changes
Feb 22, 2024
jinhoonbang
previously approved these changes
Feb 22, 2024
leeyikjiun
reviewed
Feb 23, 2024
| } | ||
|
|
||
| // on startup we want to initialize the last processed block | ||
| if startingUp { | ||
| var err2 error |
There was a problem hiding this comment.
I think it should be fine naming it as err instead of err2?
There was a problem hiding this comment.
Yeah, I think you're right that it wouldn't cause a shadowing issue.
jinhoonbang
previously approved these changes
Feb 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Sorry for the re-review request here, the PR had an orphaned goroutine in the test so it was causing failures in GH actions. Also, added a git changeset. |
jinhoonbang
previously approved these changes
Mar 15, 2024
|
looks good but there is a merge conflict again. will re approve once that's resolved |
|
kidambisrinivas
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes logic that repeatedly calls the Log Poller's
RegisterFilterfunction, which fires off a noisy warning for duplicates. Instead checks the log poller for an existing filter and registers one if not found.