core/chains/evm/client/errors.go: wrap log msgs with Sprintf (SHIP-1172) #12168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
friedemannf
changed the title
dhaidashenko
approved these changes
Feb 26, 2024
|
simsonraj
approved these changes
Feb 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
friedemannf
added a commit
that referenced
this pull request
Feb 26, 2024
snehaagni
added a commit
that referenced
this pull request
Feb 27, 2024
core/chains/evm/client/errors.go: wrap log msgs with Sprintf (#12168)
snehaagni
added a commit
that referenced
this pull request
Feb 27, 2024
snehaagni
added a commit
that referenced
this pull request
Feb 28, 2024
…ick-05b5612 Revert "core/chains/evm/client/errors.go: wrap log msgs with Sprintf (#12168)"
snehaagni
added a commit
that referenced
this pull request
Mar 4, 2024
anirudhwarrier
pushed a commit
that referenced
this pull request
Mar 4, 2024
anirudhwarrier
added a commit
that referenced
this pull request
Mar 4, 2024
snehaagni
added a commit
that referenced
this pull request
Mar 4, 2024
…2172-cherry-pick-05b5612 Add back "core/chains/evm/client/errors.go: wrap log msgs with Sprintf (#12168)"
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log statments were incorrectly containing formatting verbs when the additional arguments are actually additional log fields. This leads to errors when they're being called:
Wrapped the messages containing verbs with
fmt.Sprintfto format the string.