Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint warning fixes #12303

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Lint warning fixes #12303

merged 3 commits into from
Mar 5, 2024

Conversation

kidambisrinivas
Copy link
Collaborator

Goal

  • Fix forge lint warning issues for VRF contracts
  • Add VRF V2+ forge compiler config

@kidambisrinivas kidambisrinivas requested review from a team and RensR as code owners March 5, 2024 19:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

jinhoonbang
jinhoonbang previously approved these changes Mar 5, 2024
View reviewed changes
@kidambisrinivas kidambisrinivas requested a review from a team as a code owner March 5, 2024 19:53
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@kidambisrinivas kidambisrinivas added this pull request to the merge queue Mar 5, 2024
Merged via the queue into develop with commit df9ad53 Mar 5, 2024
109 checks passed
@kidambisrinivas kidambisrinivas deleted the vrf-v2plus-minor-updates branch March 5, 2024 22:40
kidambisrinivas added a commit that referenced this pull request Mar 18, 2024
@kidambisrinivas
Lint warning fixes (#12303)
6771934 
* Lint warning fixes

* Update go wrappers

* Prettier fix
kidambisrinivas added a commit that referenced this pull request Mar 18, 2024
@kidambisrinivas
Lint warning fixes (#12303)
77a99ca 
* Lint warning fixes

* Update go wrappers

* Prettier fix
kidambisrinivas added a commit that referenced this pull request Mar 18, 2024
@kidambisrinivas
Lint warning fixes (#12303)
6b8a8ba 
* Lint warning fixes

* Update go wrappers

* Prettier fix
kidambisrinivas added a commit that referenced this pull request Mar 18, 2024
@kidambisrinivas
Lint warning fixes (#12303)
61664ff 
* Lint warning fixes

* Update go wrappers

* Prettier fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinhoonbang jinhoonbang jinhoonbang approved these changes

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kidambisrinivas @jinhoonbang