Increase FinalityDepth & HistoryDepth defaults to match Polygon mainnet #12347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
reductionista
force-pushed
the
fix/zkevm_polygon_finality
branch
from
0b83fe6
to
279b4d4
Compare
reductionista
force-pushed
the
fix/zkevm_polygon_finality
branch
from
63d45a7
to
3897982
Compare
reductionista
force-pushed
the
fix/zkevm_polygon_finality
branch
from
3897982
to
df78bd0
Compare
We have verified that finality tags on zkevm polygon are just as far behind latest as they are on other polygon chains (often 300-500 blocks). HistoryDepth needs to be larger for the same reason, and allow room for uncles.
and increase FinalityDepth & BlockHistoryDepth for both chains
reductionista
force-pushed
the
fix/zkevm_polygon_finality
branch
from
1360890
to
049e11a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have verified that finality tags on zkevm polygon are just as far behind latest as they are on other polygon chains (often 300-500 blocks). HistoryDepth needs to be larger for the same reason, and allow room for uncles.