Increase FinalityDepth & HistoryDepth defaults to match Polygon mainnet #12348
Conversation
|
I see that you haven't updated any README files. Would it make sense to do so? |
reductionista
force-pushed
the
fix/zkevm_polygon_finality
branch
from
0b83fe6
to
279b4d4
Compare
|
You'll need to run |
reductionista
force-pushed
the
fix/zkevm_polygon_finality
branch
from
63d45a7
to
3897982
Compare
reductionista
force-pushed
the
fix/zkevm_polygon_finality
branch
from
3897982
to
df78bd0
Compare
docs/CONFIG.md
Outdated
| @@ -3993,13 +3993,13 @@ TipCapMin = '1 wei' | |||
|
|
|||
| [GasEstimator.BlockHistory] | |||
| BatchSize = 25 | |||
| BlockHistorySize = 12 | |||
| BlockHistorySize = 1000 | |||
There was a problem hiding this comment.
Why increase the number of blocks used to calculate gas?
There was a problem hiding this comment.
That was an accidental change I made at some point yesterday and rolled back soon after. It's not changed in the actual defaults, must be that I forgot to regenerate the config?
There was a problem hiding this comment.
@patrickhuie19 Thanks for catch, I've re-run "make config-docs" which removed those changes. Approve?
There was a problem hiding this comment.
Sorry just saw this, but LGTM! - my github notifications are not surfacing replies to comments :/
reductionista
dismissed stale reviews from simsonraj and prashantkumar1982
via
1afe101
We have verified that finality tags on zkevm polygon are just as far behind latest as they are on other polygon chains (often 300-500 blocks). HistoryDepth needs to be larger for the same reason, and allow room for uncles.
and increase FinalityDepth & BlockHistoryDepth for both chains
reductionista
force-pushed
the
fix/zkevm_polygon_finality
branch
from
1360890
to
049e11a
Compare
|
…et (#12348) * Increase FinalityDepth & HistoryDepth defaults to match Polygon mainnet We have verified that finality tags on zkevm polygon are just as far behind latest as they are on other polygon chains (often 300-500 blocks). HistoryDepth needs to be larger for the same reason, and allow room for uncles. * Add Cardona defaults based on Goerli and increase FinalityDepth & BlockHistoryDepth for both chains * make config-docs * pnpm changeset * Re-run "make config-docs"
We have verified that finality tags on zkevm polygon are just as far behind latest as they are on other polygon chains (often 300-500 blocks). HistoryDepth needs to be larger for the same reason, and allow room for uncles.