Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRF flat fee config validation #12355

Merged
merged 12 commits into from
Mar 12, 2024
Merged

VRF flat fee config validation #12355

merged 12 commits into from
Mar 12, 2024

Conversation

kidambisrinivas
Copy link
Collaborator

@kidambisrinivas kidambisrinivas commented Mar 8, 2024 •
edited
Loading

Updates

  • Validate if flat fee configs are configured correctly in VRF coordinator

Testing

$ forge test -vvv --match-path test/v0.8/foundry/vrf/VRFV2Plus.t.sol\
...
[PASS] testSetConfig() (gas: 74302)
Logs:
  changePrank is deprecated. Please use vm.startPrank instead.

Test result: ok. 11 passed; 0 failed; 0 skipped; finished in 4.61ms

Ran 1 test suites: 11 tests passed, 0 failed, 0 skipped (11 total tests)

@kidambisrinivas kidambisrinivas requested review from a team as code owners March 8, 2024 11:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

I see that you haven't updated any README files. Would it make sense to do so?

@kidambisrinivas kidambisrinivas changed the base branch from develop to VRF-910-data-len-check March 11, 2024 11:19
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

Base automatically changed from VRF-910-data-len-check to develop March 11, 2024 17:57
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kidambisrinivas kidambisrinivas added this pull request to the merge queue Mar 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2024
@kidambisrinivas kidambisrinivas added this pull request to the merge queue Mar 12, 2024
Merged via the queue into develop with commit 2e08d9b Mar 12, 2024
108 of 109 checks passed
@kidambisrinivas kidambisrinivas deleted the VRF-911-fee-config branch March 12, 2024 10:48
ogtownsend pushed a commit that referenced this pull request Mar 14, 2024
@kidambisrinivas @ogtownsend
VRF flat fee config validation (#12355)
15e1d96 
* fulfillRandomWords msg.data length validation

* Addressed PR comments

* Validate if flat fee configs are configured correctly

* Update flat fee discount check

* Allow fulfillmentFlatFeeLinkDiscountPPM to be equal to fulfillmentFlatFeeNativePPM

* Added changeset

* Update VRFV2Plus test

* Remove arbitrary bounds

* Remove unused error
kidambisrinivas added a commit that referenced this pull request Mar 18, 2024
@kidambisrinivas
VRF flat fee config validation (#12355)
6e75790 
* fulfillRandomWords msg.data length validation

* Addressed PR comments

* Validate if flat fee configs are configured correctly

* Update flat fee discount check

* Allow fulfillmentFlatFeeLinkDiscountPPM to be equal to fulfillmentFlatFeeNativePPM

* Added changeset

* Update VRFV2Plus test

* Remove arbitrary bounds

* Remove unused error
kidambisrinivas added a commit that referenced this pull request Mar 18, 2024
@kidambisrinivas
VRF flat fee config validation (#12355)
c3b0c04 
* fulfillRandomWords msg.data length validation

* Addressed PR comments

* Validate if flat fee configs are configured correctly

* Update flat fee discount check

* Allow fulfillmentFlatFeeLinkDiscountPPM to be equal to fulfillmentFlatFeeNativePPM

* Added changeset

* Update VRFV2Plus test

* Remove arbitrary bounds

* Remove unused error
kidambisrinivas added a commit that referenced this pull request Mar 18, 2024
@kidambisrinivas
VRF flat fee config validation (#12355)
692a883 
* fulfillRandomWords msg.data length validation

* Addressed PR comments

* Validate if flat fee configs are configured correctly

* Update flat fee discount check

* Allow fulfillmentFlatFeeLinkDiscountPPM to be equal to fulfillmentFlatFeeNativePPM

* Added changeset

* Update VRFV2Plus test

* Remove arbitrary bounds

* Remove unused error
kidambisrinivas added a commit that referenced this pull request Mar 18, 2024
@kidambisrinivas
VRF flat fee config validation (#12355)
f3b377e 
* fulfillRandomWords msg.data length validation

* Addressed PR comments

* Validate if flat fee configs are configured correctly

* Update flat fee discount check

* Allow fulfillmentFlatFeeLinkDiscountPPM to be equal to fulfillmentFlatFeeNativePPM

* Added changeset

* Update VRFV2Plus test

* Remove arbitrary bounds

* Remove unused error
kidambisrinivas added a commit that referenced this pull request Mar 27, 2024
@kidambisrinivas
VRF flat fee config validation (#12355)
97b5f8b 
* fulfillRandomWords msg.data length validation

* Addressed PR comments

* Validate if flat fee configs are configured correctly

* Update flat fee discount check

* Allow fulfillmentFlatFeeLinkDiscountPPM to be equal to fulfillmentFlatFeeNativePPM

* Added changeset

* Update VRFV2Plus test

* Remove arbitrary bounds

* Remove unused error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeyikjiun leeyikjiun leeyikjiun left review comments

@ibrajer ibrajer ibrajer approved these changes

@jinhoonbang jinhoonbang jinhoonbang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kidambisrinivas @ibrajer @leeyikjiun @jinhoonbang