Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve experience with ingresses in DevSpace #12363

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

chainchad
Copy link
Collaborator

  1. Creates a new devspace run ingress-hosts command
  2. Moves ingress output to an after:deploy hook and run a new ingress_check.sh script to check if the ingress looks to be created before displaying hostnames.
  3. Prevents output on label operations

@chainchad
Copy link
Collaborator Author

Supersedes #12362

@chainchad chainchad changed the title Improvess experience with ingresses in DevSpace Improve experience with ingresses in DevSpace Mar 9, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@chainchad chainchad added this pull request to the merge queue Mar 9, 2024
Merged via the queue into develop with commit 2a86b92 Mar 9, 2024
98 checks passed
@chainchad chainchad deleted the re-2277/crib-devspace-ingress-check branch March 9, 2024 16:42
ogtownsend pushed a commit that referenced this pull request Mar 14, 2024
* Create DevSpace command to list ingress hostnames

* Ignore scripts dir from helm chart

* Move ingress output to external script in hook and add checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants