VRF-922-VRF-V2-Plus-Wrapper-combine-SetLink-and-SetLinkEthFeed-functions-into-one-function #12368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
LGTM. We will also emit an event for this setter once #12318 is merged right? |
ibrajer
approved these changes
Mar 12, 2024
@jinhoonbang Yup, probably will merge conflict. Will resolve in that PR. |
@ibrajer The test is updated in this PR. |
…nk-and-SetLinkEthFeed-functions-into-one-function
|
leeyikjiun
deleted the
VRF-922-VRF-V2-Plus-Wrapper-combine-SetLink-and-SetLinkEthFeed-functions-into-one-function
branch
ogtownsend
pushed a commit
that referenced
this pull request
Mar 14, 2024
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 18, 2024
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 18, 2024
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 18, 2024
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 18, 2024
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine setLink and setLinkNativeFeed into a single function