Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use common interface for v2.3 #12443

Merged
merged 2 commits into from
Mar 18, 2024
Merged

use common interface for v2.3 #12443

merged 2 commits into from
Mar 18, 2024

Conversation

shileiwill
Copy link
Contributor

As title, several considerations in this PR:

  1. We use the common interface 100%, and compatible Utils as much as possible, but there is an edge case for Report. So we decided to keep the Utils2_3. We keep only the Report and removed all others. This ensures we have the right naming (linkUSD v.s. linkNative), and having the Utils2_3 doesn't break any backward compatibility.
  2. In typescript test, we replaced setConfig with setConfigTypeSafe, which means we lost coverage on setConfig. However, we have setConfig covered in foundry test.

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@FelixFan1992
Copy link
Contributor

As title, several considerations in this PR:

  1. We use the common interface 100%, and compatible Utils as much as possible, but there is an edge case for Report. So we decided to keep the Utils2_3. We keep only the Report and removed all others. This ensures we have the right naming (linkUSD v.s. linkNative), and having the Utils2_3 doesn't break any backward compatibility.
  2. In typescript test, we replaced setConfig with setConfigTypeSafe, which means we lost coverage on setConfig. However, we have setConfig covered in foundry test.

for (2), i think it's totally fine (or EVEN BETTER!) to test set config in foundry!

FelixFan1992
FelixFan1992 previously approved these changes Mar 15, 2024
@cl-sonarqube-production
Copy link

@shileiwill shileiwill added this pull request to the merge queue Mar 18, 2024
Merged via the queue into develop with commit e604a73 Mar 18, 2024
117 checks passed
@shileiwill shileiwill deleted the AUTO-9283 branch March 18, 2024 17:08
kidambisrinivas pushed a commit that referenced this pull request Mar 27, 2024
* use common interface for v2.3

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants