Split log buffer flow metric into two metrics #12444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
ogtownsend
force-pushed
the
chore/update-log-buffer-flow-metric
branch
from
9cd5e4c
to
8d09b8b
Compare
ogtownsend
force-pushed
the
chore/update-log-buffer-flow-metric
branch
from
8d09b8b
to
138c769
Compare
ogtownsend
force-pushed
the
chore/update-log-buffer-flow-metric
branch
from
138c769
to
6b18c1e
Compare
amirylm
approved these changes
Apr 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
AutomationLogsInLogBuffermetric from a gauge to a counter and add a label that allows us to split it into ingress log count and egress log count. This allows us to have more flexibility with alerting and charting