Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflows] Add JSON Schema support #12458

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

HenryNguyen5
Copy link
Collaborator

No description provided.

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@HenryNguyen5 HenryNguyen5 force-pushed the keystone/define-workflow-format-schema-ks-82 branch from 96aa0a2 to 4cc33cb Compare March 22, 2024 15:33
@HenryNguyen5 HenryNguyen5 changed the title [Workflows] Add bare minimum parser [Workflows] Add JSON Schema support Mar 22, 2024
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset.

// network: mainnet
//
// [semver regex]: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string
Type string `json:"type" jsonschema:"required,pattern=^[a-z0-9_\\-:]+@(0|[1-9]\\d*)\\.(0|[1-9]\\d*)\\.(0|[1-9]\\d*)(?:-((?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\\.(?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\\+([0-9a-zA-Z-]+(?:\\.[0-9a-zA-Z-]+)*))?$"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤮

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Nothing to do with your work, just wanted to react :P )

@HenryNguyen5 HenryNguyen5 added this pull request to the merge queue Mar 26, 2024
Merged via the queue into develop with commit 51b1347 Mar 26, 2024
104 checks passed
@HenryNguyen5 HenryNguyen5 deleted the keystone/define-workflow-format-schema-ks-82 branch March 26, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants