-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed limitTransfer gasLimit from uint32 to uint64 #12496
Merged
prashantkumar1982
merged 2 commits into
develop
from
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
Mar 21, 2024
Merged
Changed limitTransfer gasLimit from uint32 to uint64 #12496
prashantkumar1982
merged 2 commits into
develop
from
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that you haven't updated any README files. Would it make sense to do so? |
silaslenihan
force-pushed
the
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
branch
from
March 19, 2024 20:42
a101add
to
81764ac
Compare
silaslenihan
force-pushed
the
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
branch
from
March 19, 2024 21:03
ed38172
to
84e705c
Compare
silaslenihan
force-pushed
the
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
branch
from
March 19, 2024 23:14
aef0b34
to
372135b
Compare
silaslenihan
force-pushed
the
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
branch
from
March 20, 2024 14:23
9347d71
to
7d45266
Compare
silaslenihan
force-pushed
the
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
branch
from
March 20, 2024 17:42
886263f
to
e07b62f
Compare
amit-momin
previously approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
dimriou
previously approved these changes
Mar 20, 2024
prashantkumar1982
previously approved these changes
Mar 20, 2024
Signed-off-by: Silas Lenihan <sjl@lenihan.net>
silaslenihan
dismissed stale reviews from amit-momin, prashantkumar1982, and dimriou
via
March 21, 2024 13:41
7740856
silaslenihan
force-pushed
the
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
branch
from
March 21, 2024 13:41
32b6f86
to
7740856
Compare
silaslenihan
force-pushed
the
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
branch
from
March 21, 2024 15:00
524a4e5
to
fd96643
Compare
silaslenihan
force-pushed
the
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
branch
from
March 21, 2024 15:12
fd96643
to
fc82979
Compare
Quality Gate passedIssues Measures |
dimriou
approved these changes
Mar 21, 2024
prashantkumar1982
deleted the
BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64
branch
March 21, 2024 16:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.