improve some nits and refactor foundry tests #12522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
|
I see you updated files related to |
FelixFan1992
requested review from
RyanRHall and
shileiwill
and removed request for
a team and
RensR
RyanRHall
previously approved these changes
Mar 21, 2024
Comment on lines
+1023
to
+1029
| PayoutMode mode = s_payoutMode; | ||
| for (uint256 i = 0; i < billingTokens.length; i++) { | ||
| IERC20 token = billingTokens[i]; | ||
| BillingConfig memory config = billingConfigs[i]; | ||
|
|
||
| // if LINK is a billing option, payout mode must be ON_CHAIN | ||
| if (address(token) == address(i_link) && s_payoutMode == PayoutMode.OFF_CHAIN) { | ||
| if (address(token) == address(i_link) && mode == PayoutMode.OFF_CHAIN) { |
There was a problem hiding this comment.
I think this change probably increases gas, fwiw, since we read the thing into memory now
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
move addFunds() tests to foundry for auto v2.3 add tests for onTokenTransfer()
RyanRHall
approved these changes
Mar 21, 2024
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
silaslenihan
pushed a commit
that referenced
this pull request
Mar 21, 2024
* improve some nits and refactor foundry tests * add changesets * fix * fix tests * write registerUpkeep() foundry tests for auto v2.3 (#12535) move addFunds() tests to foundry for auto v2.3 add tests for onTokenTransfer() --------- Co-authored-by: Ryan Hall <RyanRHall@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
…ator (#12534) * Applied LimitMultiplier to chainSpecificGasLimit in all gas estimators * Added changeset * altered tests to use a limit multiplier of 1.5 rather than 1 * improve some nits and refactor foundry tests (#12522) * improve some nits and refactor foundry tests * add changesets * fix * fix tests * write registerUpkeep() foundry tests for auto v2.3 (#12535) move addFunds() tests to foundry for auto v2.3 add tests for onTokenTransfer() --------- Co-authored-by: Ryan Hall <RyanRHall@users.noreply.github.com> * Added error checks * updated existing tests * Extracted fee limit multiplier out of indivudal gas estimators, into WrappedEvmEstimator * Cleaned up unused LimitMultipliers * Removed unused limit multipliers in tests and cleaned up * removed chainSpecificGasLimit from BumpDynamicFee, GetDynamicFee * Fixed failing tests --------- Co-authored-by: FelixFan1992 <fankejin@gmail.com> Co-authored-by: Ryan Hall <RyanRHall@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.