Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and re-enable abandoned tx tracker #12533

Merged
merged 35 commits into from
Apr 17, 2024

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Mar 21, 2024

The tracker was disabled after a Polygon node was stuck during startup. After investigation I believe this was due to querying for all non-fatal transactions from the txStore at once causing a large query which blocked the txm startup. I re-enabled the tracker with the following changes:

  • Added batching for retrieving transactions from txStore
  • Concurrently track transactions to not block txm startup
  • Refactored start/ stop sequence and context handling
  • Removed unnecessary functions and structs
  • Ensured thread safety on all tracker methods
  • Added reset logic in txm

@DylanTinianov DylanTinianov marked this pull request as ready for review March 21, 2024 20:04
@DylanTinianov DylanTinianov requested a review from a team as a code owner March 21, 2024 20:04
@DylanTinianov DylanTinianov marked this pull request as draft March 21, 2024 20:13
@dimriou
Copy link
Collaborator

dimriou commented Mar 22, 2024

Unless we have a product request for this feature, we should pause this work until the updated tx confirmation logic gets added to the txm as it might embed this logic there.

@DylanTinianov DylanTinianov changed the title Re-enable abandoned tx tracker Fix and re-enable abandoned tx tracker Mar 24, 2024
@DylanTinianov DylanTinianov marked this pull request as ready for review March 24, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants