Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AppConfig from ChainScoped #12636

Merged
merged 30 commits into from
Apr 22, 2024
Merged

Remove AppConfig from ChainScoped #12636

merged 30 commits into from
Apr 22, 2024

Conversation

dimriou
Copy link
Collaborator

@dimriou dimriou commented Mar 29, 2024 •
edited
Loading

EVM config should be decoupled from Application Config.
Blocked by:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset.

@dimriou dimriou marked this pull request as ready for review April 10, 2024 11:04
@dimriou dimriou requested review from a team as code owners April 10, 2024 11:04
dimriou
dimriou commented Apr 10, 2024
View reviewed changes
core/chains/evm/config/chain_scoped.go Outdated
@@ -47,14 +44,10 @@ func (c *ChainScoped) BlockEmissionIdleWarningThreshold() time.Duration {
func (c *ChainScoped) Validate() (err error) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmank88 I think this check will now fail in libocr. Is there another place we can move it to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? I don't think we can change libocr types. Why are they tangled up in this?

Copy link
Contributor

@jmank88 jmank88 Apr 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, as long as it is not called by libocr, then yeah I think we can move it somewhere else, but I don't know where off the top of my head. Is there somewhere in the delegate(s) that makes sense? Whenever LocalConfig is actually used.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out LocalConfig is used in two places, here and here, and they both call ocr.SanityCheckLocalConfig() afterwards, so I'd say it's ok if we simply remove it from chain_scoped.

amit-momin
amit-momin previously approved these changes Apr 10, 2024
View reviewed changes
amit-momin
amit-momin previously approved these changes Apr 11, 2024
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
98.1% Coverage on New Code
6.2% Duplication on New Code

See analysis details on SonarQube

@dimriou dimriou added this pull request to the merge queue Apr 22, 2024
Merged via the queue into develop with commit bdc076c Apr 22, 2024
104 checks passed
@dimriou dimriou deleted the fix_configs branch April 22, 2024 18:06
This was referenced Apr 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@amit-momin amit-momin amit-momin left review comments

@cedric-cordenier cedric-cordenier cedric-cordenier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimriou @jmank88 @cedric-cordenier @amit-momin