Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KS-136] Write target fixes #12743

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

cedric-cordenier
Copy link
Contributor

  • Handle null reports correctly
  • Don't wrap the report in a list, just pass it directly as []byte
  • Use the correct interpolation variable name (report rather than inputs.report)

- Handle null reports correctly
- Don't wrap the report in a list, just pass it directly as []byte
- Use the correct interpolation variable name (`report` rather than
  `inputs.report`)
Copy link
Contributor

github-actions bot commented Apr 8, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset.

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Apr 8, 2024
Merged via the queue into develop with commit 0148439 Apr 8, 2024
104 of 105 checks passed
@cedric-cordenier cedric-cordenier deleted the KS-136-write-target-fixes branch April 8, 2024 19:24
momentmaker added a commit that referenced this pull request Apr 8, 2024
* develop:
  [KS-136] Write target fixes (#12743)
  chore/release 2.10.0 to develop (#12740)
  [KS-136] Disallow non-trigger steps with no dependent ref (#12742)
  [KS-136] Correctly handle numbers in YAML by converting them to floats or ints (#12739)
  New log buffer (#12357)
  [KS-101] Add OCR3 capability contract wrapper (#12404)
  core/services/relay/evm: switch RequestRound DB & Tracker to use sqlutil.DataSource (#12706)
  Unregister filters for old coordinator contracts contract addresses from Functions LogPollerWrapper (#12696)
momentmaker added a commit that referenced this pull request Apr 8, 2024
…ersion

* develop: (32 commits)
  [KS-136] Write target fixes (#12743)
  chore/release 2.10.0 to develop (#12740)
  [KS-136] Disallow non-trigger steps with no dependent ref (#12742)
  [KS-136] Correctly handle numbers in YAML by converting them to floats or ints (#12739)
  New log buffer (#12357)
  [KS-101] Add OCR3 capability contract wrapper (#12404)
  core/services/relay/evm: switch RequestRound DB & Tracker to use sqlutil.DataSource (#12706)
  Unregister filters for old coordinator contracts contract addresses from Functions LogPollerWrapper (#12696)
  Add table support for capability "type" property (#12622)
  Backout CRIB setup on develop. (#12705)
  fix node upgrade test (#12702)
  Reduces changeset scope to `minor` for semver (#12699)
  rm oz dep (#12700)
  @chainlink.contracts release v1.0.0 (#11714)
  feat: contracts publishing in CI (#12102)
  Bump default PG conns from 20->100; enable auto-scaling open conns for mercury (#12697)
  chore: chainlink-github-actions/* to v2.3.10 (#12694)
  LOOPP plugin config validation service (#12430)
  [TT-924] Migrate functions load tests to Seth (#12659)
  Enhance automation test config (AUTO-9430) (#12689)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants