Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TXM method signature to match TX ID type #12851

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

amit-momin
Copy link
Contributor

@amit-momin amit-momin commented Apr 16, 2024

Updated FindTxesWithAttemptsAndReceiptsByIdsAndState method signature to accept list of int64 for TX IDs instead of big.Int. This new method signature better corresponds with the field types in the Tx struct. It also fixes an incompatibility issue with pq.Array and []big.Int in the txStore method.

Copy link
Collaborator

@dimriou dimriou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you also add the reason we need to change this to the description?

@cl-sonarqube-production
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants