Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core to be compatible with changes made in chainlink-common as part of KS-120 (moving capabilities to use streams) #12857

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Update core to be compatible with changes made in chainlink-common as part of KS-120 (moving capabilities to use streams) #12857

merged 2 commits into from
Apr 19, 2024

Conversation

ettec
Copy link
Collaborator

@ettec ettec commented Apr 17, 2024 •
edited
Loading

No description provided.

@ettec ettec changed the title Update core to be compatible with changes made in chainlink-common as part of HS-120 (moving capabilities to use streams) Update core to be compatible with changes made in chainlink-common as part of KS-120 (moving capabilities to use streams) Apr 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions GitHub Actions
Copy link
Contributor

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@ettec ettec force-pushed the chore/KS-120-move-capability-callbacks-to-grpc-streams branch from c24652f to c06c1b9 Compare April 17, 2024 10:46
@ettec ettec force-pushed the chore/KS-120-move-capability-callbacks-to-grpc-streams branch from e4de81f to 22e12c8 Compare April 19, 2024 09:10
@ettec ettec force-pushed the chore/KS-120-move-capability-callbacks-to-grpc-streams branch from 22e12c8 to abb32ba Compare April 19, 2024 09:12
@ettec ettec marked this pull request as ready for review April 19, 2024 09:12
@ettec ettec requested review from a team as code owners April 19, 2024 09:12
@ettec ettec force-pushed the chore/KS-120-move-capability-callbacks-to-grpc-streams branch from abb32ba to 0598b4a Compare April 19, 2024 10:54
@ettec ettec force-pushed the chore/KS-120-move-capability-callbacks-to-grpc-streams branch from 0598b4a to 68c7eed Compare April 19, 2024 10:55
@ettec ettec force-pushed the chore/KS-120-move-capability-callbacks-to-grpc-streams branch from 68c7eed to 4530c71 Compare April 19, 2024 11:26
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
52.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Apr 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 19, 2024
@ettec ettec added this pull request to the merge queue Apr 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 19, 2024
@ettec ettec added this pull request to the merge queue Apr 19, 2024
Merged via the queue into develop with commit d90229e Apr 19, 2024
105 checks passed
@ettec ettec deleted the chore/KS-120-move-capability-callbacks-to-grpc-streams branch April 19, 2024 14:40
This was referenced Apr 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ettec @cedric-cordenier