update reserve amount of LINK after offchain settlement #12916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
shileiwill
force-pushed
the
settleNOPsOffchain
branch
from
1d06869
to
7aed150
Compare
shileiwill
commented
Apr 23, 2024
| @@ -875,6 +883,9 @@ contract NOPsSettlement is SetUp { | |||
| assertEq(i, index); | |||
| assertEq(0, balance); | |||
| } | |||
|
|
|||
| // assert reserve amount of LINK is reduced by the offchain settlement amount | |||
| assertEq(registry.getReserveAmount(address(linkToken)), prevReserveBalances - totalPayments); | |||
There was a problem hiding this comment.
reserve amount of link should be 0 since it is offchain mode, users cant deposit link to registry
add test to cover the above
shileiwill
force-pushed
the
settleNOPsOffchain
branch
from
7aed150
to
7bcd4d5
Compare
RyanRHall
previously approved these changes
Apr 24, 2024
shileiwill
force-pushed
the
settleNOPsOffchain
branch
from
7bcd4d5
to
4af6928
Compare
|
RyanRHall
approved these changes
Apr 24, 2024
This was referenced Apr 25, 2024
This was referenced Apr 25, 2024
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-10222