AUTO-10213 & AUTO-10214 & AUTO-10236: compare current gas price with user-defined max gas price in registry 2.1 pipeline #12952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixFan1992
changed the title
* AUTO-10214: compare max gas price with current gas price in simulation process * refactor and add tests * linting (#12960) * linting * 2 * fix linting * AUTO-10236 * fix go mod * update test json * improve max gas price integration tests * AUTO-10214: compare max gas price with current gas price in simulation process * refactor and add tests * linting (#12960) * linting * 2 * fix linting * create opts with latest block * add some logs * fix bug and update logs * update * update
FelixFan1992
changed the title
FelixFan1992
commented
May 6, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/gasprice/gasprice.go
Outdated
Show resolved
Hide resolved
cmalec
previously approved these changes
May 6, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/gasprice/gasprice.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/gasprice/gasprice.go
Outdated
Show resolved
Hide resolved
cmalec
reviewed
May 6, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/gasprice/gasprice.go
Show resolved
Hide resolved
cmalec
approved these changes
May 6, 2024
|
This was referenced May 6, 2024
This was referenced May 8, 2024
infiloop2
pushed a commit
that referenced
this pull request
Jun 10, 2024
…user-defined max gas price in registry 2.1 pipeline (#12952) * AUTO-10213: pass an gas estimator to registry 2.1 pipeline * update tests and add changeset * update changeset * AUTO-10214: compare max gas price with current gas price in simulation process (#12955) * AUTO-10214: compare max gas price with current gas price in simulation process * refactor and add tests * linting (#12960) * linting * 2 * fix linting * create opts with latest block * AUTO-10236: add integration tests for max gas price check (#12974) * AUTO-10214: compare max gas price with current gas price in simulation process * refactor and add tests * linting (#12960) * linting * 2 * fix linting * AUTO-10236 * fix go mod * update test json * improve max gas price integration tests * AUTO-10214: compare max gas price with current gas price in simulation process * refactor and add tests * linting (#12960) * linting * 2 * fix linting * create opts with latest block * add some logs * fix bug and update logs * update * update * update logs * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.