Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable jpfc cache by default #12966

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Enable jpfc cache by default #12966

merged 5 commits into from
Apr 25, 2024

Conversation

george-dorin
Copy link
Contributor

@george-dorin george-dorin commented Apr 25, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@george-dorin george-dorin marked this pull request as ready for review April 25, 2024 14:16
@george-dorin george-dorin requested a review from a team as a code owner April 25, 2024 14:16
ilija42
ilija42 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@george-dorin george-dorin added this pull request to the merge queue Apr 25, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Merged via the queue into develop with commit ac7d340 Apr 25, 2024
106 checks passed
@george-dorin george-dorin deleted the enable-jpfc-chache-by-default branch April 25, 2024 14:47
@app-token-issuer-infra-releng app-token-issuer-infra-releng bot mentioned this pull request Apr 25, 2024
Closed
george-dorin added a commit that referenced this pull request Apr 25, 2024
@george-dorin
Enable jpfc cache by default (#12966)
1200762 
* Draft

* Check JuelsPerFeeCoinCache before checking Disable param

* Add test

* Update NewInMemoryDataSourceCache

* Update NewInMemoryDataSourceCache
@george-dorin george-dorin mentioned this pull request Apr 25, 2024
Merged
@app-token-issuer-infra-releng app-token-issuer-infra-releng bot mentioned this pull request Apr 25, 2024
Closed
@app-token-issuer-infra-releng app-token-issuer-infra-releng bot mentioned this pull request Apr 25, 2024
Closed
This was referenced Apr 26, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@jmank88 jmank88 Awaiting requested review from jmank88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@george-dorin @cedric-cordenier @ilija42