Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finance can withdraw erc20s in offchain mode #13058

Merged
merged 1 commit into from
May 3, 2024
Merged

finance can withdraw erc20s in offchain mode #13058

merged 1 commit into from
May 3, 2024

Conversation

shileiwill
Copy link
Contributor

AUTO-10335

@shileiwill shileiwill requested a review from a team as a code owner April 30, 2024 22:42
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

RyanRHall
RyanRHall previously approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@RyanRHall RyanRHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shileiwill shileiwill requested a review from a team as a code owner May 2, 2024 17:12
@shileiwill shileiwill requested a review from RyanRHall May 2, 2024 23:01
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@shileiwill shileiwill enabled auto-merge May 3, 2024 18:41
RyanRHall
RyanRHall approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@RyanRHall RyanRHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shileiwill shileiwill added this pull request to the merge queue May 3, 2024
Merged via the queue into develop with commit a34a17a May 3, 2024
110 checks passed
@shileiwill shileiwill deleted the offchain_erc20_withdraw branch May 3, 2024 19:00
This was referenced May 3, 2024
Closed
Closed
@github-actions github-actions bot mentioned this pull request May 6, 2024
Closed
This was referenced May 6, 2024
Closed
Closed
This was referenced May 8, 2024
Draft
Draft
@github-actions github-actions bot mentioned this pull request May 16, 2024
Draft
@github-actions github-actions bot mentioned this pull request May 27, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanRHall RyanRHall RyanRHall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shileiwill @RyanRHall