KSI-189: Implement remove nodes #13102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds95
force-pushed
the
KSI-189/implement-remove-nodes
branch
from
c6d5fe6
to
57ff25e
Compare
|
Go solidity wrappers are out-of-date, regenerate them via the |
DeividasK
reviewed
May 6, 2024
Comment on lines
+290
to
+292
| if (!isOwner && msg.sender != nodeOperator.admin) revert AccessForbidden(); | ||
| delete s_nodes[p2pId]; | ||
| emit NodeRemoved(p2pId); |
There was a problem hiding this comment.
Once DON management is complete, we must validate that the node doesn't belong to any DONs. It'd be great if you could create a ticket to keep track of it.
DeividasK
previously approved these changes
May 6, 2024
Base automatically changed from
KSI-165/modify-nodes-capability-registry
to
develop
May 6, 2024 10:34
cds95
force-pushed
the
KSI-189/implement-remove-nodes
branch
from
ef32740
to
fe8f6c2
Compare
|
DeividasK
approved these changes
May 7, 2024
cedric-cordenier
approved these changes
May 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.