Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KS-193] Pass MercuryTriggerService to Mercury Transmitter #13118

Merged
merged 1 commit into from
May 9, 2024
Merged

[KS-193] Pass MercuryTriggerService to Mercury Transmitter #13118

merged 1 commit into from
May 9, 2024

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented May 6, 2024 •
edited
Loading

  1. Add EnableTriggerCapability flag to Relay config
  2. Create MercuryTriggerService lazily, on the first call to NewMercuryProvider()
  3. Make it available in the Transmitter (no-op for now)

bolekk
bolekk commented May 6, 2024
View reviewed changes
core/services/ocr2/delegate.go Outdated Show resolved Hide resolved
@bolekk bolekk changed the title CapabilityBridge to support locally-launched capability services Integrate MercuryTriggerService into Mercury Transmitter May 8, 2024
@bolekk bolekk changed the title Integrate MercuryTriggerService into Mercury Transmitter [KS-193] Pass MercuryTriggerService to Mercury Transmitter May 8, 2024
@bolekk bolekk marked this pull request as ready for review May 8, 2024 15:23
@bolekk bolekk requested a review from a team May 8, 2024 15:23
@bolekk bolekk requested a review from a team as a code owner May 8, 2024 15:23
cedric-cordenier
cedric-cordenier reviewed May 8, 2024
View reviewed changes
core/services/chainlink/application.go Outdated
@@ -179,6 +179,7 @@ type ApplicationOpts struct {
LoopRegistry *plugins.LoopRegistry
GRPCOpts loop.GRPCOpts
MercuryPool wsrpc.Pool
CapabilitiesRegistry *capabilities.Registry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use coretypes.CapabilitiesRegistry here rather than the concrete type (chainlink-common/pkg/types/core) as that will make loopification easy

cedric-cordenier
cedric-cordenier reviewed May 8, 2024
View reviewed changes
core/services/chainlink/relayer_factory.go Outdated
@@ -33,7 +34,8 @@ type RelayerFactory struct {
logger.Logger
*plugins.LoopRegistry
loop.GRPCOpts
MercuryPool wsrpc.Pool
MercuryPool wsrpc.Pool
CapabilitiesRegistry *capabilities.Registry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

cedric-cordenier
cedric-cordenier previously approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@cedric-cordenier cedric-cordenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits but otherwise LGTM

@bolekk bolekk enabled auto-merge May 8, 2024 19:37
@bolekk
[KS-193] Pass MercuryTriggerService to Mercury Transmitter
36fb4d8 
1. Add EnableTriggerCapability flag to Relay config
2. Create MercuryTriggerService lazily, on the first call to NewMercuryProvider()
3. Make it available in the Transmitter (no-op for now)
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
17.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

samsondav
samsondav approved these changes May 9, 2024
View reviewed changes
core/capabilities/syncer.go
@@ -127,21 +127,38 @@ func (s *registrySyncer) Start(ctx context.Context) error {
}
if slices.Contains(triggerDONPeers, myId) {
s.lggr.Info("member of a capability DON - starting remote publishers")

{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems weird to have mocks explicitly instantiated in application code, can we not use dependency injection here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Syncer object is soon going to be replaced with a real one.

@bolekk bolekk requested a review from krehermann May 9, 2024 20:53
@bolekk bolekk added this pull request to the merge queue May 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 9, 2024
@bolekk bolekk added this pull request to the merge queue May 9, 2024
Merged via the queue into develop with commit 6008d73 May 9, 2024
107 checks passed
@bolekk bolekk deleted the feature/KS-140-mercury branch May 9, 2024 21:47
@github-actions github-actions bot mentioned this pull request May 9, 2024
Draft
akuzni2 pushed a commit that referenced this pull request May 11, 2024
@bolekk @akuzni2
[KS-193] Pass MercuryTriggerService to Mercury Transmitter (#13118)
03f629a 
1. Add EnableTriggerCapability flag to Relay config
2. Create MercuryTriggerService lazily, on the first call to NewMercuryProvider()
3. Make it available in the Transmitter (no-op for now)
github-merge-queue bot pushed a commit that referenced this pull request May 11, 2024
@akuzni2 @dimriou
@ferglor @jmank88 @patrickhuie19 @cedric-cordenier @bolekk @matYang @Tofel @erikburt
fix metric description on mercury_transmit_queue_load (#13132)
eed5668 
* Fix metric description on mercury_transmit_queue_load

* Add changeset

* Add changesets tag

* Decouple gas tests (#12972)

* Add first version of evm utils

* Remove unused context util

* Add WSServer tests

* Add NewLegacyTransaction test

* Update NewTestChainScopedConfig to apply correct defaults

* Decouple gas package tests from core

* Move testutils

* Update paths

* Fix import error

* Add changeset

* Add logs to identify when assumptions of log queuing behaviour are violated (#12846)

* Add logs to identify when assumptions of log queuing behaviour are violated

* Add tests

* go import

* Add changeset

* Update enqueuing assumption

* Update tests

* Extract block tracking into a separate function

* Clean up outdated enqueued blocks

* Clean up imports

* Ignore reord buffer in cleanup

* Cleanup test name

* tools/docker: bump postgres to v14 (#13156)

* changed spammy error log to debug (#13153)

* [KS-186] Add custom OCR3 Capability Provider (#13137)

* [KS-193] Pass MercuryTriggerService to Mercury Transmitter (#13118)

1. Add EnableTriggerCapability flag to Relay config
2. Create MercuryTriggerService lazily, on the first call to NewMercuryProvider()
3. Make it available in the Transmitter (no-op for now)

* update changeset to include db_update tag (#13170)

* fix go-etheruem compatibility pipeline trigger (#13162)

* Revert "Add logs to identify when assumptions of log queuing behaviour are violated" (#13173)

* Revert "Add logs to identify when assumptions of log queuing behaviour are vi…"

This reverts commit 6a342ae.

* Add changeset

* chore: update solana-build-contracts for node20 (#13175)

* chore: update solana-build-contracts for node20

* chore: bump chainlink-solana version

* Decouple utils tests from core (#12993)

* Add first version of evm utils

* Remove unused context util

* Add WSServer tests

* Add NewLegacyTransaction test

* Update NewTestChainScopedConfig to apply correct defaults

* Move testutils

* Decouple utils tests from core

* Add changeset

---------

Co-authored-by: Dimitris Grigoriou <dimitris.grigoriou@smartcontract.com>
Co-authored-by: ferglor <fergal.gribben@smartcontract.com>
Co-authored-by: Jordan Krage <jmank88@gmail.com>
Co-authored-by: Patrick <patrick.huie@smartcontract.com>
Co-authored-by: Cedric <cedric.cordenier@smartcontract.com>
Co-authored-by: Bolek <1416262+bolekk@users.noreply.github.com>
Co-authored-by: Chunkai Yang <matYang@users.noreply.github.com>
Co-authored-by: Bartek Tofel <bartek.tofel@smartcontract.com>
Co-authored-by: Erik Burton <erikburt@users.noreply.github.com>
This was referenced May 15, 2024
Draft
Draft
@github-actions github-actions bot mentioned this pull request May 27, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann approved these changes

@samsondav samsondav samsondav approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier left review comments

@austinborn austinborn Awaiting requested review from austinborn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bolekk @samsondav @krehermann @cedric-cordenier