CapabilityRegistry updates #13183
Merged
CapabilityRegistry updates #13183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount-DON-struct KS-204: Add config count to DON struct
… KS-199/update-node-signer-type
KS-128: Implement remove DONs in capability registry
… KS-199/update-node-signer-type
…gner-type KS-199: Update node signer type
…fy-DON-capability-registry KS-129: Implement modify DON
cds95
force-pushed
the
use-encode-instead-of-encode-packed-capability-id
branch
from
70ea5d9
to
be9ccf5
Compare
…ity-config-interface KS-179: Update ICapabilityConfiguration interface
… KS-197/add-getters-for-entities
DeividasK
previously approved these changes
May 23, 2024
|
DeividasK
approved these changes
May 24, 2024
bolekk
approved these changes
May 24, 2024
| struct DONCapabilityConfig { | ||
| /// @notice The set of p2pIds of nodes that belong to this DON. A node (the same | ||
| // p2pId) can belong to multiple DONs. | ||
| EnumerableSet.Bytes32Set nodes; |
There was a problem hiding this comment.
The order here is not fixed. I wonder if this could cause any problems with OCR, where order of the nodes is important. I think OCR's config will just handle that but still a little concerned.
DeividasK
changed the title
Fair fair, updated 🙂 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.