-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automation test #13213
Fix automation test #13213
Conversation
@@ -1248,6 +1248,9 @@ func TestSetOffchainConfigWithMaxGasPrice(t *testing.T) { | |||
require.NoError(t, err, "Error setting upkeep offchain config") | |||
} | |||
|
|||
// sleep for 10s to make sure any in-flight performs are done | |||
time.Sleep(10 * time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a better way for performs to get done instead of hardocded time.sleep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a number of performs we expect that we can wait for using gom.Eventually
like above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's difficult to expect how many times it will perform so i use the n + 1 check from other tests to account for 1 possible in-flight request
Quality Gate passedIssues Measures |
* fix automation test flake * add changeset * update * udpate * fix lint * update
No description provided.