Pipeline Data Corruption #13286
Merged
Pipeline Data Corruption #13286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EasterTheBunny
force-pushed
the
BCF-3236-pipeline-task-order
branch
from
f7fc993
to
c6b140e
Compare
jmank88
previously approved these changes
May 21, 2024
EasterTheBunny
force-pushed
the
BCF-3236-pipeline-task-order
branch
from
c6b140e
to
2bf2fa2
Compare
samsondav
requested changes
May 22, 2024
EasterTheBunny
force-pushed
the
BCF-3236-pipeline-task-order
branch
from
2bf2fa2
to
9fa349e
Compare
EasterTheBunny
force-pushed
the
BCF-3236-pipeline-task-order
branch
from
9fa349e
to
817d909
Compare
EasterTheBunny
force-pushed
the
BCF-3236-pipeline-task-order
branch
from
25abafd
to
378a138
Compare
jmank88
previously approved these changes
May 22, 2024
samsondav
previously approved these changes
May 22, 2024
The unit test `TestDivide_Example` was acting flakey in the CI pipeline which suggested a flaw in the divide and multiply operations. When running the test, the expected result would be one of the input values or the division result in failure cases. This implied that results were either received out of order or were being sorted incorrectly. The pipeline runner does a final sort on the results, so that ruled out the received out of order possibility. On inspection of the sorting index on each task, every index was the zero value. This resulted in occasional correct and incorrect sorting, causing the test flake. To correct the problem, the test was updated such that the expected result has an index of `1`, leaving all other tasks with a `0` index.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
EasterTheBunny
force-pushed
the
BCF-3236-pipeline-task-order
branch
from
b32b1c0
to
a8edcf2
Compare
samsondav
approved these changes
May 22, 2024
|
vyzaldysanchez
approved these changes
May 22, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test
TestDivide_Examplewas acting flakey in the CI pipeline which suggested a flaw in the divide andmultiply operations. When running the test, the expected result would be one of the input values or the division
result in failure cases. This implied that results were either received out of order or were being sorted incorrectly.
The pipeline runner does a final sort on the results, so that ruled out the received out of order possibility. On
inspection of the sorting index on each task, every index was the zero value. This resulted in occasional correct
and incorrect sorting, causing the test flake.
To correct the problem, the
unsetvalue for tasks was set to-1and new checks were added to enforce 0-based indexing on explicitly set indexes.